Skip to content

feat(integration-tests): Record required components for the clp package in component_list data member within PackageConfig. #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: main
Choose a base branch
from
Draft

feat(integration-tests): Record required components for the clp package in component_list data member within PackageConfig. #1658

wants to merge 53 commits into from

Conversation

@quinntaylormitchell
Copy link
Collaborator

@quinntaylormitchell quinntaylormitchell commented Nov 25, 2025 •
edited
Loading

Description

This PR introduces the component_list data member to PackageConfig data class. The data member is used for tracking which containerized components a given CLP package configuration needs to run.

PR dependencies

This PR depends on the following being merged:

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ran the following command from clp/integration-tests:

uv run pytest -m 'package'

Both the clp-json and clp-text tests passed.

@quinntaylormitchell
Test a generic clp package start up and spin down (default: clp-text).
8e75e15
@quinntaylormitchell
Merge branch 'main' into feature branch
44ee20e
@quinntaylormitchell
Expand to clp-text and clp-json; store JSON config pairs in temp conf…
bbe0575 
…ig file; address comments.
@quinntaylormitchell
Merge branch 'main' into feature branch
5cd47f8
@quinntaylormitchell
Include and employ clp_py_utils.clp_config; refrain from using the us…
c5375eb 
…er-level clp-config.yml
@quinntaylormitchell
Lint.
2be837f
@quinntaylormitchell
Refactor; move all utility functions to utils files as appropriate.
bf14b5e
@quinntaylormitchell
Add comments.
27b7f5b
@quinntaylormitchell
Streamline logger calls.
e041f0e
@quinntaylormitchell
Deduplicate fixture code.
75672fc
@quinntaylormitchell
Merge branch 'main' into feature branch
0822a79
@quinntaylormitchell
Change method of clp_config import; temporary, will change again once y…
2df9515 
…-scope#1549 is merged.
@quinntaylormitchell
Generalize code so that it's better equipped to handle future CLP_MOD…
63f3ae4 
…E_CONFIGS other than clp-text and clp-json
@quinntaylormitchell
Merge branch 'main' into feature branch
0011447
@quinntaylormitchell
Combine PackageConfig, PackageModeConfig, and PackageInstanceConfig i…
0ff9465 
…nto one class.
@quinntaylormitchell
Employ a 'CLPConfig'-centric approach rather than 'dict'-centric.
cdcfaee
@quinntaylormitchell
Store list of required components for each mode
53e7343
@quinntaylormitchell
Generalize the method by which the mode of operation is determined.
796ffe3
@quinntaylormitchell
Move all mode-related utilities to their own file.
bae12de
@quinntaylormitchell
Minor error.
9c9ef74
@quinntaylormitchell
Move load_yaml_to_dict to general utilities file.
0f3dcd5
@quinntaylormitchell
Add taskfile tasks for package tests.
f9865a8
@quinntaylormitchell
Address rabbit comments.
865e9ed
@quinntaylormitchell
Add mariadb_config install for linting purposes (will be unecessary a…
09d5200 
…fter y-scope#1549).
@quinntaylormitchell
Lint YAML.
5fffc32
@quinntaylormitchell
Merge branch 'main' into feature branch
571f313
@quinntaylormitchell
Adapt code after y-scope#1549 merge.
e348be0
@quinntaylormitchell
Merge branch 'main' into feature branch
30f186f
@quinntaylormitchell
Merge branch 'main' into feature branch
e5da7e9
@quinntaylormitchell
Merge branch 'main' into feature branch
292ec70
quinntaylormitchell and others added 23 commits November 11, 2025 16:25
@quinntaylormitchell
Remove 'python -m'.
0c4cfa4
@quinntaylormitchell
Address Bill-hbrhbr comments.
bee738a
@quinntaylormitchell
Brush up docstrings.
49eaf97
@quinntaylormitchell
Merge branch 'main' into feature branch
e3c4a3b
@quinntaylormitchell
Adapt to PascalCase ClpConfig.
4cd92e6
@quinntaylormitchell
Merge branch 'main' into feature branch
87c4809
@quinntaylormitchell
Address Bill's comments; add helper function that returns a list of r…
baddcfe 
…equired components.
@quinntaylormitchell
Rabbit.
7cf597d
@quinntaylormitchell
Refactor PackageConfig and PackageInstance classes into three separat…
8372a9f 
…e classes.
@Bill-hbrhbr
Apply suggestions from code review
b92ee22
@Bill-hbrhbr
Merge branch 'main' into testing-start-stop
f950df0
@Bill-hbrhbr
lint fix and variable substitution
aac6fcb
@Bill-hbrhbr @coderabbitai
Update according to coderabbit AI suggestion.
9f995b9 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Bill-hbrhbr
Merge branch 'main' into testing-start-stop
03cb974
@quinntaylormitchell
Apply Bill's comments.
0e0567a
@quinntaylormitchell
Merge branch 'main' into feature branch
d44ab95
@quinntaylormitchell
Add ClpConfig data member to PackageConfig class; use 'fixt_' at begi…
324ade4 
…nning of fixture names.
@quinntaylormitchell
Merge branch 'main' into feature branch
e7e79e1
@quinntaylormitchell
Post-merge main.
7116cfc
@quinntaylormitchell
Remove return from _write_temp_config_file.
3471168
@quinntaylormitchell
Remove unecessary logging statements.
a324248
@quinntaylormitchell
Move content to other PRs.
6caf53a
@quinntaylormitchell
Add code from 1437 re. component list.
e967175
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Nov 25, 2025
Open
Draft
Draft
@quinntaylormitchell quinntaylormitchell changed the title feat(integration-tests): Add component_list data member to PackageConfig data class. feat(integration-tests): Record required components for the clp package in component_list data member within PackageConfig. Nov 25, 2025
This was referenced Nov 25, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quinntaylormitchell @Bill-hbrhbr